Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Hashing #4276

Open
bw-solana opened this issue Jan 3, 2025 · 0 comments
Open

Performance: Hashing #4276

bw-solana opened this issue Jan 3, 2025 · 0 comments
Assignees
@vadorovsky @bw-solana

Comments

@bw-solana
Copy link

bw-solana commented Jan 3, 2025 •
edited
Loading

We use sip hash (the default) for a lot of indexing into hashmaps when we don’t need so much collision resistance and could use a more lightweight hasher like ahash.

AccountsDB (see FD example)
@bw-solana bw-solana moved this to In progress in Agave Performance Jan 3, 2025
@bw-solana bw-solana self-assigned this Jan 3, 2025
@vadorovsky vadorovsky mentioned this issue Jan 3, 2025
Draft
@vadorovsky vadorovsky self-assigned this Jan 3, 2025
vadorovsky added a commit to vadorovsky/agave that referenced this issue Jan 6, 2025
@vadorovsky
accounts-db: Improve hashing of the read-only cache
377fbcd 
`DashMap` uses SipHash by default. Change it to AHash, which is more
lightweight.

Ref anza-xyz#4276
@vadorovsky vadorovsky mentioned this issue Jan 6, 2025
Merged
vadorovsky added a commit to vadorovsky/agave that referenced this issue Jan 6, 2025
@vadorovsky
accounts-db: Improve hashing of the read-only cache
54507a5 
`DashMap` uses SipHash by default. Change it to AHash, which is more
lightweight.

Ref anza-xyz#4276
vadorovsky added a commit to vadorovsky/agave that referenced this issue Jan 6, 2025
@vadorovsky
accounts-db: Improve hashing of the read-only cache
4628220 
`DashMap` uses SipHash by default. Change it to AHash, which is more
lightweight.

Ref anza-xyz#4276
vadorovsky added a commit that referenced this issue Jan 7, 2025
@vadorovsky
accounts-db: Improve hashing of the read-only cache (#4300)
2415647 
`DashMap` uses SipHash by default. Change it to AHash, which is more
lightweight.

Ref #4276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadorovsky vadorovsky

@bw-solana bw-solana

Labels
None yet
Projects
Agave Performance
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vadorovsky @bw-solana