Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Contributors Guide #12

Open
Cynfusion opened this issue Jul 2, 2015 · 11 comments
Open

Contributors Guide #12

Cynfusion opened this issue Jul 2, 2015 · 11 comments

Comments

@Cynfusion
Copy link
Member

Seems like this would be a good first step as we are moving towards our own model of how we want to work.

Suggest starting with https://github.com/nodejs/io.js/blob/master/COLLABORATOR_GUIDE.md and
https://github.com/nodejs/io.js/blob/master/CONTRIBUTING.md as guidelines, but with our own secret sauce and priorities for the project.

I'd put this as a pretty high priority for the docs group.

@christiansmith
Copy link
Member

Agreed on priority. I'll post a few thoughts on content specific to this project here later today.

@christiansmith
Copy link
Member

Git message conventions we use to generate the changelog need to be documented or referenced in the contributors guide.

@christiansmith
Copy link
Member

Here are a few more topics that ought to be covered:

  • code conventions
  • pull requests – how to group/separate commits, etc
  • code reviews
  • testing – how to run tests, testing conventions, when tests are required, etc.
  • licensing (i.e., don't copy/paste GPL'd code, etc)
  • call for contributions – some folks may want to get involved but don't know where to start. It would be good to point out some low hanging fruit.

Some of this may overlap a bit with governance, the CLA issue, etc.

@bnb
Copy link
Contributor

bnb commented Jul 3, 2015

I can work on this - I'll send a PR in the next few days.

@bnb bnb self-assigned this Jul 3, 2015
@christiansmith
Copy link
Member

@bnb let's try to work in the open as much as possible. Once you start drafting this up, I think you'll find we still have a lot of questions to answer.

@Cynfusion
Copy link
Member Author

As we move forward on this, I'd expect we would want to be sure and cover (among other things, such as the list above):
-How we work ( @christiansmith please weigh in here especially)
-What we value (openness, honesty, collaboration, clean code) ( @christiansmith among other things I am sure)
-Issues and Pull Requests
-Technical HowTo
-Issue Contributions
-Code Contributions
-Some kind of "Hot Top Ten" things people can jump in to easily

How are we coming, @bnb?

@adalinesimonian
Copy link
Member

Is there an update on this issue?

@Cynfusion
Copy link
Member Author

Yes, it's in my repository still. I suggest we meet w Christian this week and discuss and then merge it.

@adalinesimonian
Copy link
Member

Sweet! I'm super excited.

@adalinesimonian
Copy link
Member

PR #22

@adalinesimonian
Copy link
Member

PR #22 has been manually merged by @christiansmith. Marking issue as needing review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants