Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Force Rounded Borders on Windows #10

Open
http-samc opened this issue Jun 19, 2021 · 2 comments
Open

[Enhancement] Force Rounded Borders on Windows #10

http-samc opened this issue Jun 19, 2021 · 2 comments
Labels
enhancement New feature or request pr welcome

Comments

@http-samc
Copy link

Hi, loving the project. One thing that helps make the presentation more aesthetic (in addition to the frameless aspect) is rounded corners. Needless to say, OSX already does this automatically, but for Windows users, it would help a lot.

I don't use JS in my workflow very often, but it seems that setting the transparent flag to true in the browser initialization and appending some sort of border-radius styling onto the body of the page should do the trick.

If you want, I can make the PR, though I haven't written JS in a few years so it might take longer than it should (feel free to do it yourself if you know the details).

There's a good chance I could be doing something wrong too, regardless, here's where I got the idea.

@antfu
Copy link
Owner

antfu commented Jun 19, 2021

Yes, we could. As the transparent window in electron has come hard caveats, I'd prefer to have it under and cli options. PR welcome, thanks

@antfu antfu added enhancement New feature or request pr welcome labels Jun 19, 2021
@alexanderniebuhr
Copy link
Contributor

questionable if we can check for windows version, in electron os package?
Win 11 has native rounded borders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

No branches or pull requests

3 participants