Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve required object computation for submodules #2

Open
andreaskurth opened this issue Mar 26, 2021 · 0 comments
Open

Improve required object computation for submodules #2

andreaskurth opened this issue Mar 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@andreaskurth
Copy link
Owner

Required objects are currently computed using git log, which stops at submodule boundaries.
Thus, for a repository that looks like

Memora.yml
some_dir/
submodule/
  bar/
  foo/

an artifact that depends on submodule/foo will miss in the cache also when submodule/bar changes. This leads to "false misses".

Instead, Memora should recognize submodule as submodule, descend into it, find the required commit for foo, and then find out which commit corresponds to this commit in the root repository. The last part might be the trickiest, because there is not necessarily a one-to-one correspondence between commits in the submodule and commits in the root repository.

@andreaskurth andreaskurth added the enhancement New feature or request label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant