Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code still up to date? #18

Open
MikLang opened this issue Sep 26, 2018 · 8 comments
Open

Code still up to date? #18

MikLang opened this issue Sep 26, 2018 · 8 comments

Comments

@MikLang
Copy link

MikLang commented Sep 26, 2018

I installed the package via pip install and had to change a lot in order to make it work, wherefore I wonder wether this is the most up to date manual?

Issues -> fixes I had to do:
from pysankey import sankey -> from pySankey import sankey (otherwise cant find module)
sankey(df... -> sankey.sankey(.... (since we do not import the function directly)
figureName -> figure_name (otherwise it doesn't work)

So you may want to update the example?
Thank you

@Pierre-Sassoulas
Copy link
Contributor

Hi,

This is fixed in #14, sorry for the time it took you to fix. @anazalea could you merge this and update the pypi version ? It would permit to use pysankey as a dependency instead of copy pasting the code in django survey and report.

Thank you in advance.

@Pierre-Sassoulas
Copy link
Contributor

Pierre-Sassoulas commented Dec 12, 2018

I released a beta with the last working code as pySankeyBeta. You can install it with :

pip install pySankeyBeta

Also fixed a bug preventing to release current master branch on Pypi here : d53bfd3

@veliona
Copy link

veliona commented Jan 7, 2022

@Pierre-Sassoulas Could you help me with the imports?

After installing, I tried importing like this as recommended:
from pySankey import sankey

However, this didn't work so I tried installing via pip install pySankeyBeta and then importing like this from pySankeyBeta import sankey

I didn't manage to import it after all, any idea what's happening?

@Pierre-Sassoulas
Copy link
Contributor

Seeing the error you get would be helpful to be able to know what is happenning exactly. Can you import pySankeyBeta ? What is the result of pip freeze ?

@veliona
Copy link

veliona commented Jan 9, 2022

@Pierre-Sassoulas Cannot import pySankeyBeta. Both versions are there:
pySankey==0.0.1 pySankeyBeta==1.3.0

@Pierre-Sassoulas
Copy link
Contributor

Try removing pySankey there might be incompatibility between them. You can also check the content of your virtualenv to see what is happening.

@alexsomoza
Copy link

Have remove pySankey and install pySankeyBeta and run example, but ......

import matplotlib.pyplot as plt
import pySankeyBeta
from pySankeyBeta import sankey
%matplotlib inline
import pandas as pd
pd.options.display.max_rows=20


ModuleNotFoundError Traceback (most recent call last)
in
1 import matplotlib.pyplot as plt
----> 2 import pySankeyBeta
3 from pySankeyBeta import sankey
4 get_ipython().run_line_magic('matplotlib', 'inline')
5 import pandas as pd

ModuleNotFoundError: No module named 'pySankeyBeta'

@Pierre-Sassoulas
Copy link
Contributor

The import in the code should stay the same: 'from pysankey' :) only the pypi name is different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants