Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve does not inherit virtual enviroments #28

Open
gastmaier opened this issue Jan 9, 2025 · 1 comment
Open

Serve does not inherit virtual enviroments #28

gastmaier opened this issue Jan 9, 2025 · 1 comment

Comments

@gastmaier
Copy link
Contributor

gastmaier commented Jan 9, 2025

When using adoc serve, a new shell is created that does not inherit the virtual enviroment, if any, this causes adoc serve to fail with missing dependencies while the regular make html still works, making extra confusing for the user.

The current behaviour is

regular install inside the venv:
user:  works
dev: exit gracefully

development install inside the venv:
user: works
dev: works

development install outside the venv with packages inside the venv:
user: doesn't work
dev: doesn't work
* cannot access packages inside the venv, even the shell has it activated.

User refers to without the -r flag and dev with it.

References:
https://docs.python.org/3/library/sys.html#sys.executable
https://stackoverflow.com/questions/64761870/python-subprocess-doesnt-inherit-virtual-environment

@gastmaier
Copy link
Contributor Author

Won't fix.
The user that wants to use the virtual environment should also do the development install inside the venv.

Future commits will improve warnings and add notes to clarify on the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant