Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for port numbers in URLs #10

Open
ameenmaali opened this issue Jun 7, 2020 · 1 comment
Open

Account for port numbers in URLs #10

ameenmaali opened this issue Jun 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ameenmaali
Copy link
Owner

Probably makes sense to discard ports when assessing for duplication, but account for something like:

https://site.com:443/home
https://site.com/home
@ameenmaali ameenmaali mentioned this issue Jun 7, 2020
Closed
@ameenmaali ameenmaali added the enhancement New feature or request label Jun 7, 2020
@larskraemer
Copy link
Contributor

#17 Also solves this.
I think the only place a ':' can occur in a hostname is before the port, so discarding everything after a ':' should work for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ameenmaali @larskraemer