Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gapi library and just redirect to a google login page #106

Open
J-avery32 opened this issue Jun 28, 2021 · 0 comments
Open

Remove gapi library and just redirect to a google login page #106

J-avery32 opened this issue Jun 28, 2021 · 0 comments
Assignees
@J-avery32 @dylanmcreynolds
Labels
enhancement New feature or request

Comments

@J-avery32
Copy link
Collaborator

From Dylan on issue #51:

I am considering fixing this by remove the whole gapi thing. Rather than a modal window, we can redirect the user to the google page, sending it our redirect ui. This flow is pretty standard OCID/OAuth2, and our code will should with other providers without vendor-specific javascript code.
@J-avery32 J-avery32 added the enhancement New feature or request label Jun 28, 2021
@J-avery32 J-avery32 changed the title Remove gapi library and just redirect to a google loginh page Remove gapi library and just redirect to a google login page Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-avery32 J-avery32

@dylanmcreynolds dylanmcreynolds

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@J-avery32 @dylanmcreynolds