From 889058c522e08995ac5323b7821dcc6802b0b9c8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 7 Jan 2025 13:34:09 +0000 Subject: [PATCH 1/3] Bump govuk_publishing_components from 46.4.0 to 47.0.0 Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 46.4.0 to 47.0.0. - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md) - [Commits](https://github.com/alphagov/govuk_publishing_components/compare/v46.4.0...v47.0.0) --- updated-dependencies: - dependency-name: govuk_publishing_components dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index cdd8ffd570..0863a00f6b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -100,7 +100,6 @@ GEM rack-test (>= 0.6.3) regexp_parser (>= 1.5, < 3.0) xpath (~> 3.2) - chartkick (5.1.2) climate_control (1.2.0) coderay (1.1.3) concurrent-ruby (1.3.4) @@ -168,8 +167,7 @@ GEM govuk_personalisation (1.1.0) plek (>= 1.9.0) rails (>= 6, < 9) - govuk_publishing_components (46.4.0) - chartkick + govuk_publishing_components (47.0.0) govuk_app_config govuk_personalisation (>= 0.7.0) kramdown @@ -258,7 +256,7 @@ GEM multi_json (1.15.0) multi_xml (0.7.1) bigdecimal (~> 3.1) - net-imap (0.5.4) + net-imap (0.5.5) date net-protocol net-pop (0.1.2) @@ -533,7 +531,8 @@ GEM rack (3.1.8) rack-proxy (0.7.7) rack - rack-session (2.0.0) + rack-session (2.1.0) + base64 (>= 0.1.0) rack (>= 3.0.0) rack-test (2.2.0) rack (>= 1.3) @@ -724,7 +723,8 @@ GEM hashdiff (>= 0.4.0, < 2.0.0) webrick (1.9.1) websocket (1.2.10) - websocket-driver (0.7.6) + websocket-driver (0.7.7) + base64 websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) xpath (3.2.0) From 8b42ae55c8a6dae6dad4c84fffe9fb20d53b42e9 Mon Sep 17 00:00:00 2001 From: Andy Sellick Date: Tue, 7 Jan 2025 14:21:41 +0000 Subject: [PATCH 2/3] Remove reference to deleted chart JS --- app/assets/javascripts/dependencies.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/assets/javascripts/dependencies.js b/app/assets/javascripts/dependencies.js index f0bd46f4ed..756fdd5135 100644 --- a/app/assets/javascripts/dependencies.js +++ b/app/assets/javascripts/dependencies.js @@ -11,6 +11,4 @@ //= require govuk_publishing_components/components/table //= require govuk_publishing_components/components/tabs -//= require govuk_publishing_components/components/chart - //= require govuk_web_banners/dependencies From 11651fceca918102d29ef4bc96684ecab2541a39 Mon Sep 17 00:00:00 2001 From: Andy Sellick Date: Tue, 7 Jan 2025 14:29:20 +0000 Subject: [PATCH 3/3] Fix failing tests - markup for component has changed --- spec/system/licence_transaction_spec.rb | 2 +- spec/system/place_spec.rb | 2 +- spec/system/transaction_spec.rb | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/system/licence_transaction_spec.rb b/spec/system/licence_transaction_spec.rb index a66d5fd939..4bfbffa7ab 100644 --- a/spec/system/licence_transaction_spec.rb +++ b/spec/system/licence_transaction_spec.rb @@ -48,7 +48,7 @@ expect(page).to have_title("Licence to kill - GOV.UK", exact: true) end within("#content") do - within("h1.gem-c-heading") { expect(page).to have_title("Licence to kill") } + within(".gem-c-heading h1") { expect(page).to have_title("Licence to kill") } within(".postcode-search-form") do expect(page).to have_field("Enter a postcode") expect(page).to have_css("button", text: "Find") diff --git a/spec/system/place_spec.rb b/spec/system/place_spec.rb index a43e707ece..2f31151ed5 100644 --- a/spec/system/place_spec.rb +++ b/spec/system/place_spec.rb @@ -78,7 +78,7 @@ end within("#content") do - within("h1.gem-c-heading") do + within(".gem-c-heading h1") do expect(page).to have_title("Find a passport interview office") end diff --git a/spec/system/transaction_spec.rb b/spec/system/transaction_spec.rb index 89369c75f5..9b8cfa1418 100644 --- a/spec/system/transaction_spec.rb +++ b/spec/system/transaction_spec.rb @@ -43,7 +43,7 @@ end within("#content") do - within("h1.gem-c-heading") { expect(page).to have_title("Carrots") } + within(".gem-c-heading h1") { expect(page).to have_title("Carrots") } within(".article-container") do within("section.intro") do expect(page).to have_selector(".get-started-intro", text: "This is the introduction to carrots") @@ -159,7 +159,7 @@ expect(page.status_code).to eq(200) expect(page).to have_button_as_link("Start now", href: "http://cti-staging.voa.gov.uk/cti/inits.asp") - within("h1.gem-c-heading") do + within(".gem-c-heading h1") do expect(page).to have_title("Check your Council Tax band (staging)") end