-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove new Asset Manager asset files from NFS once they have been uploaded to S3 #323
Comments
#328 is somewhat relevant to this issue. |
#328 has now been merged. |
As a precursor to this I'm currently looking at extending the examples in As a precursor to the above, I'm looking at making it possible to use the fake S3 functionality within the specs. And in order to do this I'm first going to address a problem with the configuration of this which I highlighted in this comment. |
I'm also planning to address this bug as part of the above work: #281 |
I've opened #373 to do this. |
All Asset Manager assets are now stored and served from S3, so there is no longer any need to store the asset files on NFS as well as S3. The asset files will still need to be saved to NFS on upload so that the Sidekiq workers (which might be on a different machine) can access the file for virus scanning and S3 upload. However, once the file has been uploaded to S3, we should be able to delete the file from NFS.
Note that we'll need to be careful that methods on the
Asset
class which rely on an underlying file being present continue to work in a sensible fashion when the underlying file has been removed.Note also that we'll also need to remove asset files for existing assets after we've done this.
The text was updated successfully, but these errors were encountered: