Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure to more easily apply visual cue for zoom users enhancement #755

Open
owenatgov opened this issue Oct 29, 2024 · 0 comments

Comments

@owenatgov
Copy link
Contributor

What

Add to the autocomplete's render output to make it easier to apply an enhancement to the GOV.UK Design System's site search, implemented in alphagov/govuk-design-system#4220. These changes would be:

  • a wrapper around the ul menu element which we could attach the visual separator to as a pseudo element
  • an extra class on the input when a dropdown is visible to make it easier to target changes linked to the visual enhancement

Why

This is in response to alphagov/govuk-design-system#4015, an issue raised by a DAC audit on the GOV.UK Design System website. Our solution would theoretically benefit everyone so it makes sense to move this upstream.

We started this on the autocomplete originally in #753 but opted to rebuild it directly on our website since we'd need to restyle it anyway after launch and this meant we could test it and launch it sooner and in situ. Now that we've done this, we should distribute it more widely.

In addition, adjusting the rendered markup will make this change a lot easier to manage. The styling for this solution using only the input and menu ul is more complex than it needs to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant