Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracking] ECDSA signature generation does not follow RFC-6979 #837

Open
zerosnacks opened this issue Jan 3, 2025 · 0 comments
Open

[Tracking] ECDSA signature generation does not follow RFC-6979 #837

zerosnacks opened this issue Jan 3, 2025 · 0 comments
Labels
blocked bug Something isn't working

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Jan 3, 2025 •
edited
Loading

Component

primitives

Describe the feature you would like

From foundry-rs/foundry#9499 by pmerkleplant

The ECDSA signatures generated by the vm.sign() cheatcode do not strictly follow RFC-6979. For more info regarding the details, see this analysis.

Note that the underlying ECDSA functionality is provided via RustCrypto which fixed the issue in a recent prerelease, see RustCrypto/elliptic-curves#1100.

Tracking ticket for updating k256 crate (as it is used and re-exported here) to 0.14 once it is out of pre-release

Additional context

No response
@zerosnacks zerosnacks added enhancement New feature or request blocked labels Jan 3, 2025
@zerosnacks zerosnacks mentioned this issue Jan 3, 2025
Open
@zerosnacks zerosnacks added bug Something isn't working and removed enhancement New feature or request labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zerosnacks