Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README is wrong about send_devise_notification method placement #57

Open
letiesperon opened this issue Feb 27, 2020 · 1 comment
Open

Comments

@letiesperon
Copy link

The following part of the README:

The [Devise README](https://github.com/plataformatec/devise#activejob-integration) describes how to use ActiveJob to deliver emails in the background. Normally you would place the following code in your `User` model, however when using _devise-multi_email_ you should place this in the `Email` model.

does not seem to be correct. If I put the method send_devise_notification on the Email model, the debugger does not hit it. If I place it on the User model, the debugger stops. Should we drop this part of the README?

@allenwq
Copy link
Owner

allenwq commented Mar 1, 2020

Thanks @letiesperon , you comment might be valid, it has been some time and I am no long working on Rails related projects.

Could you help with more investigation? does the email get send to the primary one in active job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants