From e6035c11a1bb19afbf989780ff1e7da215d313ae Mon Sep 17 00:00:00 2001 From: Andrei Zhlobich Date: Tue, 11 May 2021 12:07:00 +0200 Subject: [PATCH] BREAK BUILD: fail some tests, enable test_cli (was already broken) --- .github/workflows/python-app.yml | 9 ++++++--- bigflow/bigquery/dataset_configuration.py | 2 +- bigflow/commons.py | 2 +- test/buildd/dataflow/test_depscheck.py | 1 + test/cli/__init__.py | 0 5 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 test/cli/__init__.py diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml index d18d5ba6..5bc8f1ec 100644 --- a/.github/workflows/python-app.yml +++ b/.github/workflows/python-app.yml @@ -14,8 +14,11 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - name: Set up Python 3.7 + + - name: Checkout + uses: actions/checkout@v2 + + - name: Setup Python uses: actions/setup-python@v2 with: python-version: 3.7 @@ -31,7 +34,7 @@ jobs: curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add - sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic test" sudo apt update - sudo apt install docker-ce docker + sudo apt install docker-ce docker -v - name: Install dependencies diff --git a/bigflow/bigquery/dataset_configuration.py b/bigflow/bigquery/dataset_configuration.py index b0f30f66..ac3c7d90 100644 --- a/bigflow/bigquery/dataset_configuration.py +++ b/bigflow/bigquery/dataset_configuration.py @@ -14,7 +14,7 @@ def __init__(self, is_master: bool = True, is_default: bool = True): all_properties = (properties or {}).copy() - all_properties['project_id'] = project_id + all_properties['project_idxxx'] = project_id all_properties['dataset_name'] = dataset_name all_properties['internal_tables'] = internal_tables or [] all_properties['external_tables'] = external_tables or {} diff --git a/bigflow/commons.py b/bigflow/commons.py index df78e2ef..a3e01396 100644 --- a/bigflow/commons.py +++ b/bigflow/commons.py @@ -209,7 +209,7 @@ def run_process( duration = time.time() - start logger.debug("done in %s seconds, code %d", format(duration, ".2f"), process.returncode) - return stdout + return stdout + "bad" def generate_file_hash(fname: Path, algorithm: str = 'sha256') -> str: diff --git a/test/buildd/dataflow/test_depscheck.py b/test/buildd/dataflow/test_depscheck.py index 7b537e34..72372679 100644 --- a/test/buildd/dataflow/test_depscheck.py +++ b/test/buildd/dataflow/test_depscheck.py @@ -54,6 +54,7 @@ def test_check_dataflow_conflicts(self): @mock.patch('bigflow.build.dataflow.dependency_checker.detect_py_version') @mock.patch('bigflow.build.spec.get_project_spec') + @unittest.skip("too slow - tmp disable") def test_generate_dataflow_pinfile(self, get_project_spec, detect_py_version): # given detect_py_version.return_value = "3.7" diff --git a/test/cli/__init__.py b/test/cli/__init__.py new file mode 100644 index 00000000..e69de29b