Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloadWorker未处理fd.Close()的出错，导致可能丢数据 #362

Open
polyrabbit opened this issue Dec 23, 2022 · 0 comments
Open

downloadWorker未处理fd.Close()的出错，导致可能丢数据 #362

polyrabbit opened this issue Dec 23, 2022 · 0 comments

Comments

@polyrabbit
Copy link

写本地文件，fd.Close()会把最后一段 page cache 里的数据刷下去，这一步有可能发生 io error，但 sdk 里面并没有捕捉，这会导致用户认为下载成功了，但实际文件缺少了一段 io。

aliyun-oss-go-sdk/oss/download.go

Lines 161 to 162 in 25a7611

fd.Close()
results <- part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@polyrabbit