Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlLocaleKey - problem #13

Open
lzsheng opened this issue Jul 12, 2017 · 1 comment
Open

urlLocaleKey - problem #13

lzsheng opened this issue Jul 12, 2017 · 1 comment

Comments

@lzsheng
Copy link

lzsheng commented Jul 12, 2017

intl.determineLocale({
  urlLocaleKey: "lang"
});

i use react-router hashHistory
url-example-A(standard): http://www.xxx.com/index.html?lang=en#/test
url-example-B(non-standard): http://www.xxx.com/index.html#/test?lang=en

url-example-A:

window.location.search == '?lang=en'
window.location.hash == '#/test'

url-example-B:

window.location.search == ''
window.location.hash == '#/test?lang=en'

urlLocaleKey only stand by standard-URL ,can u stand by non-standard-URL like "http://www.xxx.com/index.html#/test?lang=en"

@cwtuan
Copy link
Collaborator

cwtuan commented Jul 12, 2017

@lzsheng Yes, it's good idea. Will be implemented in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants