Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Github action to publish the docker #17

Open
baruchiro opened this issue Apr 13, 2020 · 10 comments
Open

Create Github action to publish the docker #17

baruchiro opened this issue Apr 13, 2020 · 10 comments

Comments

@baruchiro
Copy link

You can use GitHub Actions to auto publish the docker image to docker registry.

I can help you with that, but I have no "media server" (respbery PI or something), so it is currently a low priority for me.

@alfem
Copy link
Owner

alfem commented Apr 13, 2020

Thanks for the suggestion, but I am not the author of docker files (I just coded this bot as a proof of concept). Perhaps @mitto98 could help with this.

@mitto98
Copy link
Contributor

mitto98 commented Apr 13, 2020

If you want, since the repo is yours, you can publish it freely on docker hub, otherwise, I can do it.

@alfem
Copy link
Owner

alfem commented Apr 14, 2020

My laptop conked out a few days ago. If you think an image of this bot will be helpful, feel free to upload it.

I am no a docker expert but images are architecture dependent, aren't they?

@baruchiro
Copy link
Author

All we need is Docker Login credentials. I think @alfem should be the owner of these credentials since he is the owner of this repo.
Anyone can create the docker in the registry and give the passwords to @alfem.

And I think Github Action for publishing will be good.

@mitto98
Copy link
Contributor

mitto98 commented Apr 14, 2020

Yes, they are platform dependent but is possible to build arm in an x86 machine.
Tomorrow after work I'll create the image with, at least, support for x86.
I don't think is a good idea to give his docker hub credentials to strangers, but whenever you want I can give you the ownership of the docker hub repository.

@mitto98
Copy link
Contributor

mitto98 commented Apr 16, 2020

Since I'm not the owner of the repo I'm not allowed to add an action, but I've created a pr with some edits and a script to build and pull the image.
@alfem what do you think about adding a license?

@alfem
Copy link
Owner

alfem commented Apr 17, 2020

Not a bad idea, @mitto98. I am not interested in earning millions of $$ with this bot :-D so a GPL3 could work.

@baruchiro
Copy link
Author

baruchiro commented Apr 23, 2020

@mitto98 I'm working on the brother repo- https://github.com/alfem/telegram-download-daemon.
I want to publish a docker, do you think it will be best if these two docker-brothers will be under the same user?

Because that is what I thinking, and I want you to create another item in your Dockerhub account to hold the second docker.

Please come to talk with me in alfem/telegram-download-daemon#3

@mitto98
Copy link
Contributor

mitto98 commented Apr 23, 2020

Currently, I'm working on a university assignment, so, you know, lack of time.
I've created the repository (https://hub.docker.com/repository/docker/mitto98/telegram-download-daemon), let me know when you have finished, so I can build and push it.
I'm excited to try this script 🤩

@baruchiro
Copy link
Author

Please create a comment here so we will discuss in the right place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants