You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can get a PR going if their is willingness to merge it.
Thanks!
The text was updated successfully, but these errors were encountered:
bilby91
changed the title
Potential race condition when incrementing and setting expiration
Atomicity issue when incrementing and setting expiration
Nov 4, 2019
@bilby91 sounds reasonable to me - if you want to do a PR, a couple requests
looks like actually it's incr_timeseries that should use the transaction, to keep minutes stats in sync with hours stats
there are other places in the codebase that are subject to the same problem, e.g. push_history in history.rb - if you tackled these as well that would be 💯
Hello,
We had a couple of issues recently where some time series values got an empty string without expiration.
Shouldn't the code in https://github.com/alanpeabody/resque-job-stats/blob/v0.4.2/lib/resque/plugins/job_stats/timeseries.rb#L50 be wrapped with a
MULTI
command ?We can get a PR going if their is willingness to merge it.
Thanks!
The text was updated successfully, but these errors were encountered: