Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-projections: Accept scala proto descriptors in Scala #958

Closed
johanandren opened this issue Aug 18, 2023 · 2 comments
Closed

grpc-projections: Accept scala proto descriptors in Scala #958

johanandren opened this issue Aug 18, 2023 · 2 comments

Comments

@johanandren
Copy link
Member

Right now you have to do:

// FIXME why not just StringValue.scalaDescriptor for scala API?
.withProtobufDescriptors(StringValue.javaDescriptor.getFile :: Nil)

Accepting the Descriptor and turning it into a file descriptor ourselves would also be convenient.
@johanandren johanandren mentioned this issue Aug 18, 2023
Merged
@johanandren
Copy link
Member Author

Looks as though it would require a transform via the descriptor proto, but there is something lacking there upstream which may be a problem: scalapb/ScalaPB#934

@johanandren
Copy link
Member Author

Let's close this for now, it's not that big of a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanandren