Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context input in api-types.go-Service interface #44

Open
byeongsu-hong opened this issue Nov 14, 2018 · 3 comments
Open

Add context input in api-types.go-Service interface #44

byeongsu-hong opened this issue Nov 14, 2018 · 3 comments
Assignees
@byeongsu-hong
Labels
enhancement 기존 기능 리팩토링 및 퍼포먼스 개선

Comments

@byeongsu-hong
Copy link
Contributor

Start() -> Start(context.Context)
@byeongsu-hong byeongsu-hong added the enhancement 기존 기능 리팩토링 및 퍼포먼스 개선 label Nov 14, 2018
@byeongsu-hong byeongsu-hong added this to the Airbloc Public Alpha milestone Nov 14, 2018
@byeongsu-hong byeongsu-hong self-assigned this Nov 14, 2018
@therne
Copy link
Contributor

therne commented Nov 15, 2018

왜 Public Alpha 마일스톤인가요?

@byeongsu-hong byeongsu-hong removed this from the Airbloc Public Alpha milestone Nov 19, 2018
@byeongsu-hong
Copy link
Contributor Author

죄송합니다..
아 그리고 안넣어도 될것같은데 만약 넣으려면 interface에 정의되있는 Stop함수를 없애야 할듯합니당

@therne
Copy link
Contributor

therne commented Nov 20, 2018

맞아여 지금 Manager 내부에서 하는 모든 함수 콜에서 줘야할 Context 인자들을 전부 context.Background()로 먹이고 있는데, 이거 조정가능하게 만들어야 할듯

@byeongsu-hong byeongsu-hong mentioned this issue Nov 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byeongsu-hong byeongsu-hong

Labels
enhancement 기존 기능 리팩토링 및 퍼포먼스 개선
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@therne @byeongsu-hong