Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated metrics not computed correctly #3242

Open
kirschnj opened this issue Nov 1, 2024 · 1 comment
Open

Aggregated metrics not computed correctly #3242

kirschnj opened this issue Nov 1, 2024 · 1 comment
Labels
help wanted Extra attention is needed type / bug Issue type: something isn't working

Comments

@kirschnj
Copy link

kirschnj commented Nov 1, 2024

🐛 Bug

Aggregated values (mean, median) are not displayed correctly.

To reproduce

Log several values for different contexts, where some values appear multiple times as below:

import aim
run = aim.Run(experiment="test")

for step in range(3):
    run.track(0, name="test", step=step, context=dict(context=0))
    run.track(0, name="test", step=step, context=dict(context=1))
    run.track(1, name="test", step=step, context=dict(context=2))

run.close()

In the UI, both median and mean are incorrectly shown as 0.5.

image

Expected behavior

In the example above, the mean per step is 0.33 and the median is 0.

Environment

  • Aim v3.25.0 on Linux

Additional context

The issue appears to be that only unique values in the group are used to compute the mean/median. The issue doesn't appear with distinct values (e.g. 0, 0.2, 1).

@kirschnj kirschnj added help wanted Extra attention is needed type / bug Issue type: something isn't working labels Nov 1, 2024
@mihran113
Copy link
Contributor

Hey @kirschnj! Thanks a lot for noticing this. 🙌 I'll open the PR with a fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type / bug Issue type: something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants