Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permutation invariant training #6

Open
yoyolicoris opened this issue Jan 28, 2023 · 5 comments
Open

permutation invariant training #6

yoyolicoris opened this issue Jan 28, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request mdx for mdx track
Milestone

Comments

@yoyolicoris
Copy link
Member

yoyolicoris commented Jan 28, 2023

For bleeding/label noise tracks

@yoyolicoris yoyolicoris added enhancement New feature or request mdx for mdx track labels Jan 28, 2023
@ben-hayes
Copy link
Collaborator

@ben-hayes
Copy link
Collaborator

to keep memory requirement in O(n^2) rather than O(n!), better to adapt FLoss and TLoss to accommodate dim parameters to allow permutations to be evaluated in parallel

@ben-hayes
Copy link
Collaborator

the way some loss fns are currently implemented (e.g. the sdr-combination loss in sdr_loss) are bound to specific shapes and numbers of targets, so either I refactor all these to accommodate the general PIT wrapper, or I scrap the wrapper approach and just hard-code PIT variants of loss functions we're interested in

@yoyolicoris
Copy link
Member Author

yoyolicoris commented Feb 8, 2023

I prefer the latter approach since the loss fns are meant to be replaceable (using configs), and we can make as many as we want. :)

@ben-hayes
Copy link
Collaborator

yeah fair point! will switch it over.

@yoyolicoris yoyolicoris assigned yoyolicoris and unassigned ben-hayes Feb 17, 2023
@yoyolicoris yoyolicoris added this to the Phase 1 end milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mdx for mdx track
Projects
None yet
Development

No branches or pull requests

2 participants