Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't invoke a custom webpack config function #315

Closed
nksfrank opened this issue Apr 5, 2023 · 2 comments
Closed

doesn't invoke a custom webpack config function #315

nksfrank opened this issue Apr 5, 2023 · 2 comments

Comments

@nksfrank
Copy link

nksfrank commented Apr 5, 2023

trying to set up size-limit and use my webpack.config.js that exports a function for building the webpack config object.

size-limit doesn't seem to accept a webpack config as a function.

const clientConfig = (argv, env) => ({
  mode: env.mode,
  devtool: env.mode === 'production' ? 'source-map' : 'eval',
  name: 'client',
  /* ... */
});

console.log('file is read');
module.exports = (argv, env) => {
  console.log('function is invoked', argv, env);
  return clientConfig(argv, env);
};

the function is invoked is never printed

@ai
Copy link
Owner

ai commented Apr 5, 2023

Yes, it doesn’t.

Send PR if you have an idea how to add support.

@ai
Copy link
Owner

ai commented Nov 1, 2023

The fix was released in 10.0.2.

@ai ai closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants