Hasura websockets operation active not decrease

[vnmedeiros]

Hi, I'm a little confused.
In the metric hasura_websockets_operations_active even when all hasura websockets/subscriptions are no active, the view does not decrease the number of the operations actives.
Could it be a problem collecting the metric?

see example:

[afitzek]

There could be a problem when collecting the metric.

Which hasura version are you using?

I'll try to reproduce it, when I find some time.

[noisyscanner]

Back from the dead... 💀

Just ran into what seems like this issue (??) - it looks like Hasura does not emit a stopped log when the underlying websocket is closed - eg if I closed the browser tab rather than unsubscribing presumably?
Can see in this screenshot - 2 websockets opened, some subscriptions were started, and then the websockets were closed, but no stopped logs were ever written.

Does seem like a bug on Hasura's end - I don't have much faith in them fixing this in any reasonable timeframe though.
I wonder if it would be feasible for hasura-metric-adapter to keep a count of operations per socket id, and then decrement the counter by that when a websocket closed event is received. 🤔

**EDIT: ** will have a bash at fixing this in Hasura itself, and revert back to the above solution if that fails 🤞🏻