Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one central place for orbital calculations #241

Open
hornig opened this issue Apr 3, 2021 · 3 comments
Open

one central place for orbital calculations #241

hornig opened this issue Apr 3, 2021 · 3 comments

Comments

@hornig
Copy link
Collaborator

hornig commented Apr 3, 2021

Hi,

during the years, the code grew with several places for almost the same calculations.

just two examples:
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/gauss_method.py#L100-L135
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/gauss_method.py#L552-L640
and
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/orbital_elements.py

maybe there are even more.

it is time to clean that up a bit, make them more universal, and find a better place for it.

so the tasks are:
identify the different duplicates.
find a better, central location
implement an universal approach (by calling them, by naming convention and more.
testing them that they keep the expected results.

@Mohitvilasgiri
Copy link

Respected sir,
My name is Mohit Giri, a 3rd-year student studying Electronics and Telecommunication Engineering from St. Vincent Palloti College of Engineering and Technology. I am familiar with python I want to contribute to this project to increase my knowledge and improve my skills.

@KingShark1
Copy link

KingShark1 commented May 31, 2021

going to take up this issue! @hornig would you assign this one?

@hornig
Copy link
Collaborator Author

hornig commented Jun 19, 2021

going to take up this issue! @hornig would you assign this one?

hey @KingShark1 you can just start on this. why assigning? you also wanted to tackle other ones and then we waited on you.
I still wait :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants