From ebba617e0297c8b5488d9ef2fa759a85924afe41 Mon Sep 17 00:00:00 2001 From: Ivan Krutov Date: Fri, 21 May 2021 17:53:50 +0300 Subject: [PATCH 1/2] Completely removed vnc: images from documentation --- docs/faq.adoc | 4 +--- docs/starting-selenoid-manually.adoc | 13 +++++++------ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/faq.adoc b/docs/faq.adoc index ed69a696..a81eab9b 100644 --- a/docs/faq.adoc +++ b/docs/faq.adoc @@ -92,10 +92,8 @@ When running Selenoid as Docker container video feature can be not working (beca **Can't get VNC feature to work: Disconnected** -Please check the following: +Please check that you have `enableVNC = true` capability in your tests -. You have `enableVNC = true` capability in your tests -. You are using browser images with `vnc` in their name, e.g. `selenoid/vnc:firefox:58.0`. **Seeing black screen with a cross in VNC window** diff --git a/docs/starting-selenoid-manually.adoc b/docs/starting-selenoid-manually.adoc index 3d3ba1f2..1d3fe318 100644 --- a/docs/starting-selenoid-manually.adoc +++ b/docs/starting-selenoid-manually.adoc @@ -11,14 +11,14 @@ . Create `config/browsers.json` configuration file with content: + .config/browsers.json -[source,javascript] +[source,json] ---- { "firefox": { "default": "57.0", "versions": { "57.0": { - "image": "selenoid/vnc:firefox_57.0", + "image": "selenoid/firefox:88.0", "port": "4444", "path": "/wd/hub" } @@ -31,7 +31,7 @@ NOTE: For Chrome and Opera images "path" is "/" instead of "/wd/hub" + . Pull browser Docker image: + -`$ docker pull selenoid/vnc:firefox_57.0`. +`$ docker pull selenoid/firefox:88.0`. === Browser Images We maintain a set of prebuilt Docker container images for different browsers including: @@ -48,20 +48,21 @@ Feel free to create issues or request images for new versions. ==== . Complete list of browser images can be found in <> . These images support all UTF-8 locales. This can be important if you want to save files using national alphabet symbols. You can enable your preferred locale in browsers configuration file by setting respective environment variables: -``` +[source,json] +---- { "chrome": { "default": "64.0", "versions": { "64.0": { - "image": "selenoid/vnc:chrome_64.0", + "image": "selenoid/chrome:90.0", //... "env" : ["LANG=ru_RU.UTF-8", "LANGUAGE=ru:en", "LC_ALL=ru_RU.UTF-8"] } } } } -``` +---- ==== === Start Selenoid From 1939bbaabe7cd112ebc6d751af0440d101b8bb85 Mon Sep 17 00:00:00 2001 From: Ivan Krutov Date: Fri, 21 May 2021 17:54:44 +0300 Subject: [PATCH 2/2] Setting Host header to localhost (needed for recent Safari driver) --- selenoid.go | 1 + 1 file changed, 1 insertion(+) diff --git a/selenoid.go b/selenoid.go index 49987313..5016bb53 100644 --- a/selenoid.go +++ b/selenoid.go @@ -506,6 +506,7 @@ func proxy(w http.ResponseWriter, r *http.Request) { } } r.URL.Host, r.URL.Path = sess.URL.Host, path.Clean(sess.URL.Path+r.URL.Path) + r.Host = "localhost" return } r.URL.Path = paths.Error