Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reopen issue AmountToLotSize works incorrect #653

Closed
ramilexe opened this issue Jan 4, 2025 · 2 comments · Fixed by #654
Closed

reopen issue AmountToLotSize works incorrect #653

ramilexe opened this issue Jan 4, 2025 · 2 comments · Fixed by #654
Assignees
@adshao

Comments

@ramilexe
Copy link

ramilexe commented Jan 4, 2025

This issue is closed but still not fixed
@adshao
Copy link
Owner

adshao commented Jan 4, 2025

Hi @ramilexe , thank you for this update, I'll take a look at it this weekend.

@adshao adshao self-assigned this Jan 4, 2025
@adshao adshao mentioned this issue Jan 4, 2025
Merged
@adshao
Copy link
Owner

adshao commented Jan 4, 2025 •
edited
Loading

@ramilexe The bug was caused by a rounding error with float64. I’ve fixed it by using strings to calculate the correct lot size. Please try version 2.7.1 to confirm if the issue has been resolved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adshao adshao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use string decimal to calculate lot size adshao/go-binance
2 participants
@ramilexe @adshao