Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modify batch orders feature #647 #648

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

khanbekov
Copy link
Contributor

Implementation of order batches modification and test for it. Presented in the official api of binance: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Modify-Multiple-Orders

Implementation of order batches modification and test for it. Presented in the official api of binance: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Modify-Multiple-Orders
@khanbekov
Copy link
Contributor Author

Hello, I wanted to add a little more detail about this commit.

This PR adds support for the Modify Multiple Orders endpoint in Binance’s USD-Margined Futures API. I noticed this feature wasn’t implemented in the library while working on my trading system. This is very handy when you need to update multiple orders at once, rather than canceling and re-creating them or modifying them one at a time. This reduces the load on the API, which allows you to avoid a ban from the exchange API.

The implementation follows the style of existing batch order methods (like placing and canceling), so it should feel consistent. I’ve also added tests to ensure everything works as expected.

Let me know if you have any feedback! Thanks. @adshao

v2/futures/order_service.go Outdated Show resolved Hide resolved
v2/futures/order_service.go Outdated Show resolved Hide resolved
Added MarketOrder structure for ModifyBatchOrderService. Also modified tests for these changes.
@khanbekov
Copy link
Contributor Author

Hello.
Review again, please. I've made requested changes. Thanks @adshao

@xyq-c-cpp xyq-c-cpp requested a review from adshao December 16, 2024 02:03
@adshao adshao merged commit 7c57681 into adshao:master Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants