Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modify Multiple Orders Endpoint - USD-M Futures #647

Closed
khanbekov opened this issue Dec 5, 2024 · 2 comments
Closed

Add Modify Multiple Orders Endpoint - USD-M Futures #647

khanbekov opened this issue Dec 5, 2024 · 2 comments

Comments

@khanbekov
Copy link
Contributor

Hello,

I noticed that the Modify Multiple Orders endpoint, described in the Binance API documentation (link), is not currently implemented in this library.

Adding support for this functionality would be very helpful for batch order modifications. I encountered the need for this method while working on a system I'm developing.

The library already includes methods for placing and canceling multiple orders, so the absence of this endpoint seems like an oversight.

I plan to work on a PR to implement this feature in the near future.
@xyq-c-cpp
Copy link
Collaborator

okay, that's fine if you can push a PR to implement this feature. thanks so much. @khanbekov

khanbekov added a commit to khanbekov/go-binance that referenced this issue Dec 6, 2024
@khanbekov
Add modify batch orders feature
2ca8359 
Implementation of order batches modification and test for it. Presented in the official api of binance: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Modify-Multiple-Orders

Resolve adshao#647
khanbekov added a commit to khanbekov/go-binance that referenced this issue Dec 6, 2024
@khanbekov
Add modify batch orders feature adshao#647
d9999dc 
Implementation of order batches modification and test for it. Presented in the official api of binance: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Modify-Multiple-Orders
adshao pushed a commit that referenced this issue Dec 16, 2024
@khanbekov
Add modify batch orders feature #647 (#648)
7c57681 
* Add modify batch orders feature #647

Implementation of order batches modification and test for it. Presented in the official api of binance: https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Modify-Multiple-Orders

* Add MarketOrder instead using Service

Added MarketOrder structure for ModifyBatchOrderService. Also modified tests for these changes.
@xyq-c-cpp
Copy link
Collaborator

had merged, close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xyq-c-cpp @khanbekov