fix signature error while the content includes @

[xyq-c-cpp]

1. fix Fix /sapi/v1/sub-account/universalTransfer Signature for this request is not valid. #639 , This is the fundamental approach to fix this issue. Fix issue [Signature error when request parameter content includes @]
   1. Currently, only the binance module has been repaired, and other modules have not been involved yet. Do not modify them for now.

[adshao]

Has the bug been confirmed? Is there a better way to fix it without hardcoding the special symbols?

[adshao]

#639 (comment)

[xyq-c-cpp]

Has the bug been confirmed? Is there a better way to fix it without hardcoding the special symbols?

Yes, I have confirmed that the modified code has been tested in real time environment, for the interface POST /sapi/v1/sub-account/universalTransfer.
Other open-source libraries binance-futures-connector-python also perform similar processing after URL encoding. At present, this is a perfect approach, it seems. @adshao

[xyq-c-cpp]

The response appears to be @, which is a secure string and does not require URL encoding. @adshao

[adshao]

Has the bug been confirmed? Is there a better way to fix it without hardcoding the special symbols?

Yes, I have confirmed that the modified code has been tested in real time environment, for the interface POST /sapi/v1/sub-account/universalTransfer. Other open-source libraries binance-futures-connector-python also perform similar processing after URL encoding. At present, this is a perfect approach, it seems. @adshao

OK, please add tests for this change and include comments explaining why the ‘@’ symbol must be escaped.

[xyq-c-cpp]

Has the bug been confirmed? Is there a better way to fix it without hardcoding the special symbols?

Yes, I have confirmed that the modified code has been tested in real time environment, for the interface POST /sapi/v1/sub-account/universalTransfer. Other open-source libraries binance-futures-connector-python also perform similar processing after URL encoding. At present, this is a perfect approach, it seems. @adshao

OK, please add tests for this change and include comments explaining why the ‘@’ symbol must be escaped.

'@' is a safe character, no need to escape. Supplementing this test is not effective, as how to handle this special character depends on the feedback from the Binance real disk interface. The actual test has been conducted, and if possible, you can also test and verify it. @adshao

[xyq-c-cpp]

In actual testing, when passing in query_string, @ escape or no escape is acceptable. When passing in the body, @ escape is not allowed, @ not escape is allowed. So not escaping is the best solution. @adshao

[xyq-c-cpp]

In actual testing, when passing in query_string, @ escape or no escape is acceptable. When passing in the body, @ escape is not allowed, @ not escape is allowed. So not escaping is the best solution. @adshao

When parameters are passed through request-body, the main issue is that the signature is correct when the @ in the signature content is not escaped; Signature error if escaped. @adshao