Fix /sapi/v1/sub-account/universalTransfer Signature for this request is not valid.

[hlongvu]

A fix for wrong params and formParams set on api /sapi/v1/sub-account/universalTransfer

[xyq-c-cpp]

If setFormParam is not replaced, can the problem be found in parseRequest ? @hlongvu

[xyq-c-cpp]

Have you ever used this interface in real life? I'm testing other similar interfaces with setFormParam and see if they work fine @hlongvu

[hlongvu]

I am using the fix on my bot and it's working fine.
the original v2.6.1 throw the "Signature for this request is not valid" error.
I take a look on the api example here and they put all variable on params https://www.postman.com/api-noob/binance-apis/request/hji0sli/universal-transfer-for-master-account

[adshao]

I am using the fix on my bot and it's working fine. the original v2.6.1 throw the "Signature for this request is not valid" error. I take a look on the api example here and they put all variable on params https://www.postman.com/api-noob/binance-apis/request/hji0sli/universal-transfer-for-master-account

Hi @hlongvu , Could you please share the code you used along with the debug log?
In the binance API document, both params in form and query string are accepted: doc

[hlongvu]

debuglog.log
@adshao @xyq-c-cpp here is the log for error on my end

Code:

masterAccount.Client.NewSubAccountUniversalTransferService(). FromEmail(masterAccount.AccountEmail). ToEmail(subAccountConfig.AccountEmail). FromAccountType("SPOT"). ToAccountType("USDT_FUTURE"). Asset("USDT"). Amount(fmt.Sprintf("%.0f", amount)). RecvWindow(50000). Do(context.Background())

[hlongvu]

Maybe related ccxt/ccxt#19491

[adshao]

Maybe related ccxt/ccxt#19491

Thank you @hlongvu , I don't think this bug is caused by setFormParams, it should be some special symbols in email format which is encoded by URLEncode. @xyq-c-cpp is trying to fix it in #646