From ec291e0b19ee87b94eaf0bc9e6b13a52095c94ae Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Tue, 14 Nov 2023 19:19:28 +0800 Subject: [PATCH 1/6] fix(breaking-change): update for nodes 18 and 20 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3c91fd7..e50dd23 100644 --- a/package.json +++ b/package.json @@ -46,6 +46,6 @@ "typescript": "^5.1.6" }, "engines": { - "node": ">=16.0.0" + "node": ">=18" } } From f815028056771bc9daa4cb171a620b48fdd290f1 Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Tue, 14 Nov 2023 21:43:59 +0800 Subject: [PATCH 2/6] Update app-smoke-test.yml --- .github/workflows/app-smoke-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/app-smoke-test.yml b/.github/workflows/app-smoke-test.yml index 39e8bd9..bde9389 100644 --- a/.github/workflows/app-smoke-test.yml +++ b/.github/workflows/app-smoke-test.yml @@ -12,13 +12,13 @@ jobs: strategy: max-parallel: 1 matrix: - node: [14, 16] + node-version: [18.x, 20.x] os: [ubuntu-latest] steps: - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node }} + node-version: ${{ matrix.node-version }} - name: Setup CLI uses: actions/checkout@master with: @@ -112,5 +112,5 @@ jobs: env: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} SLACK_TITLE: 'Node version' - SLACK_MESSAGE: ${{ matrix.node }} + SLACK_MESSAGE: ${{ matrix.node-version }} SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }} From 690c8c748a247879e252ffca2069225adaa8095b Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Tue, 14 Nov 2023 21:44:58 +0800 Subject: [PATCH 3/6] Update app-test.yml --- .github/workflows/app-test.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/app-test.yml b/.github/workflows/app-test.yml index e38c84f..ac661c7 100644 --- a/.github/workflows/app-test.yml +++ b/.github/workflows/app-test.yml @@ -11,15 +11,15 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node: [16.7.0] + node-version: [18] os: [ubuntu-latest] steps: - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node }} + - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v1 with: - node-version: ${{ matrix.node }} + node-version: ${{ matrix.node-version }} - run: npm i --package-lock --package-lock-only - run: npm ci - name: Run E2E Tests @@ -48,7 +48,7 @@ jobs: run: | git config user.name github-actions git config user.email github-actions@github.com - echo "- $(date) Node ${{ matrix.node }} ${{ job.status == 'success' && '🎉 success' || job.status }}" >> logs/run.md + echo "- $(date) Node ${{ matrix.node-version }} ${{ job.status == 'success' && '🎉 success' || job.status }}" >> logs/run.md git add logs/run.md git commit -m "generated" git push @@ -56,12 +56,12 @@ jobs: if: ${{ success() && (github.event_name == 'pull_request' || github.event_name == 'push') }} uses: codecov/codecov-action@v3.1.1 with: - name: ${{ runner.os }} node.js ${{ matrix.node }} + name: ${{ runner.os }} node.js ${{ matrix.node-version }} - name: Slack Notification if: ${{ failure() && (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') }} uses: rtCamp/action-slack-notify@v2 env: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} SLACK_TITLE: 'Node version' - SLACK_MESSAGE: ${{ matrix.node }} + SLACK_MESSAGE: ${{ matrix.node-version }} SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }} From 86ee2c85c5f17500558a3b371ec59b559b9dd91d Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Tue, 14 Nov 2023 21:45:17 +0800 Subject: [PATCH 4/6] Update node.js.yml --- .github/workflows/node.js.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 8fc8d8a..5dc0cf1 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -14,7 +14,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [16.x] + node-version: [18.x] os: [ubuntu-latest, windows-latest] steps: @@ -33,4 +33,4 @@ jobs: if: success() uses: codecov/codecov-action@v3.1.1 with: - name: ${{ runner.os }} node.js ${{ matrix.node-version }} \ No newline at end of file + name: ${{ runner.os }} node.js ${{ matrix.node-version }} From bcd13e4a34dfeea4d82fe312e1f1472f3f473f3f Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Tue, 21 Nov 2023 12:28:25 +0800 Subject: [PATCH 5/6] revert package.json engines.node --- package.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/package.json b/package.json index e50dd23..1d8a73e 100644 --- a/package.json +++ b/package.json @@ -44,8 +44,5 @@ "jest": "^29.6.2", "stdout-stderr": "^0.1.13", "typescript": "^5.1.6" - }, - "engines": { - "node": ">=18" } } From 66a3e6721342ed16c1356a4120242986ea783de6 Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Tue, 21 Nov 2023 21:42:02 +0800 Subject: [PATCH 6/6] add >=8.3.0 to package.json engines.node property --- package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package.json b/package.json index 1d8a73e..272e2fd 100644 --- a/package.json +++ b/package.json @@ -44,5 +44,8 @@ "jest": "^29.6.2", "stdout-stderr": "^0.1.13", "typescript": "^5.1.6" + }, + "engines": { + "node": ">=8.3.0" } }