Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon is requested for each time it is used on the page #151

Open
kptdobe opened this issue Dec 2, 2022 · 0 comments
Open

icon is requested for each time it is used on the page #151

kptdobe opened this issue Dec 2, 2022 · 0 comments
Assignees
@kptdobe

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Dec 2, 2022

If you use the same icon 20 times on the page, you will see 20 requests being made in the network tab. This can be optimised by requesting only each icon once and potentially cache the result for the next decorateIcons calls.
@kptdobe kptdobe self-assigned this Dec 2, 2022
@kptdobe kptdobe changed the title icon is requested for time it is used on the page icon is requested for each time it is used on the page Dec 2, 2022
This was referenced Dec 2, 2022
Closed
Closed
omprakashgupta1995 referenced this issue in WWWPiramalFinanceCOM/piramalfinance Jul 2, 2024
@Sm1pleScr1pt
Merge pull request #151 from shamalijadhav/feature/component-creation
8feef25 
Feature/component creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kptdobe kptdobe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve decorateicons kptdobe/netcentric
feat: request icons only once adobe/aem-boilerplate
1 participant
@kptdobe