If accessibility is disabled dialogs cannot be opened

[chris-steele]

Observations:

• unopened dialogs are styled display:none by default
• showModal is not called if accessibility has been disabled
• problem began with core v6.60.3

[chris-steele]

@oliverfoster don't suppose you could have a look at this, could you?

[oliverfoster]

I don't understand what you mean by 'if accessibility is disabled". Could you clarify plz?

[chris-steele]

Hi @oliverfoster, sorry for not being clearer, by disabling accessibility I meant setting the following:

"_accessibility": {
    "_isEnabled": false

ref: https://github.com/adaptlearning/adapt_framework/blob/master/src/course/config.json#L14

[oliverfoster]

I thought we'd removed that option. Why would you set this to false?

[chris-steele]

I thought we'd removed that option. Why would you set this to false?

it's a jolly good question, I don't think it would give you much advantage in any arena?

Thank you so much for that PR 👍

[oliverfoster]

Why are you setting it to _isEnabled: false? How did you find this bug? I need to know to tell you if the fix will work.