Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in _ariaLevel calculations #547

Closed
guywillis opened this issue Jun 5, 2024 · 0 comments · Fixed by #548
Closed

Error in _ariaLevel calculations #547

guywillis opened this issue Jun 5, 2024 · 0 comments · Fixed by #548
Assignees
@guywillis
Labels
bug Something isn't working

Comments

@guywillis
Copy link
Contributor

guywillis commented Jun 5, 2024 •
edited by oliverfoster
Loading

Subject of the issue

If an _ariaLevel is explicitly set but there is no displayTitle the calculation does not include the _ariaLevel in the relative offset.

Your environment

  • Master FW & AT

Proposed fix

Include explicitly set _ariaLevel in relative offset calculation.
@guywillis guywillis added the bug Something isn't working label Jun 5, 2024
@guywillis guywillis self-assigned this Jun 5, 2024
@guywillis guywillis moved this from New to Assigned in adapt_framework: The TODO Board Jun 5, 2024
@guywillis guywillis mentioned this issue Jun 5, 2024
Merged
@oliverfoster oliverfoster moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jun 5, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Include explicitly set ariaLevel (fixes #547) adaptlearning/adapt-contrib-core
1 participant
@guywillis