Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to switch getInitialProps to getServerSideProps? #95

Open
newKeating opened this issue Jan 28, 2021 · 3 comments
Open

Is it possible to switch getInitialProps to getServerSideProps? #95

newKeating opened this issue Jan 28, 2021 · 3 comments

Comments

@newKeating
Copy link

newKeating commented Jan 28, 2021

Well, since this withApollo hoc is using getInitialProps for ssr, there is a conflict when using getServerSideProps on a page component.


const Restaurant: NextPage<IProps> = ({ id }) => {
  console.log("id", id);
  const { data, loading } = useRestaurantQuery({
    variables: {
      input: {
        restaurantId: id,
      },
    },
  });

  console.log("loading", loading);
  console.log("data", data);
  if (loading) {
    return <div>Loading...</div>;
  }

  return (
    <div>
      restaurant
      <div>{data?.restaurant.result?.name}</div>
    </div>
  );
};

export default withApollo({ssr: true})(Restaurant);

export const getServerSideProps: GetServerSideProps = async (ctx) => {
  console.log("ctx", ctx);

  const { id } = ctx.query;
  if (!id) {
    return {
      props: {},
    };
  }

  return {
    props: { id: parseInt(id as string) },
  };
};

Screen Shot 2021-01-28 at 12 38 45 PM

So, I'm looking for a way to make withApollo hoc utlizing getServerSideProps for "ssr" mode.

Could there be a way to do that?

@besSejrani
Copy link

Yes, it would be great to have that change, since next has moved to version 10.1

@herbievine
Copy link

Please introduce this @adamsoffer. But for now, is there a workaround or a temporary fix?

@AxelReid
Copy link

Is there any action on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants