Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disputing advice to SHA256 password before sending to server #1

Open
ernsheong opened this issue Aug 18, 2017 · 2 comments
Open

Disputing advice to SHA256 password before sending to server #1

ernsheong opened this issue Aug 18, 2017 · 2 comments

Comments

@ernsheong
Copy link

First up, thanks for this. I was looking for a concrete example, and here it is!

Password is SHA256 hashed on the client before being sent to the server (never simply rely on https and send plaintext passwords over the wire!!)

I would argue that this makes little difference to password security. If we can't trust HTTPS, say an attacked managed to sniff on our hash, the attacker would then simply continue to use that hash to authenticate with the server. There is no benefit to gain from the client hashing the password.

https://stackoverflow.com/questions/1380168/does-it-make-security-sense-to-hash-password-on-client-end

@ernsheong ernsheong changed the title Advice to SHA256 password before sending to server Disputing advice to SHA256 password before sending to server Aug 18, 2017
@adam-hanna
Copy link
Owner

adam-hanna commented Aug 18, 2017

Very true.

The only benefit of client side hashing that I can think of is that clients often re-use passwords on multiple sites. If a server was ever compromised, the client's plain text password might also be compromised. A hacker then might try to login to the client's facebook or bank account.

Now, if everyone did client side hashing without salt, it would be a moot point.

@ernsheong
Copy link
Author

ernsheong commented Aug 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants