From df0c499945dcda0032f5d2742afe77ec327b31dd Mon Sep 17 00:00:00 2001 From: Ankita Victor Date: Tue, 16 Apr 2024 09:59:22 -0700 Subject: [PATCH] Remove global -Wno-stringop-overflow, -Wno-stringop-overread compiler options (#9432) Summary: This PR makes a change to remove the globally applied `-Wno-stringop-overflow` and `-Wno-stringop-overread` compiler options for GNU to warn for buffer overflows and undefined behaviour from reading past the end of the source buffer. PR https://github.com/facebookincubator/velox/pull/4618 originally disabled it. Meant to address https://github.com/facebookincubator/velox/discussions/9469 Pull Request resolved: https://github.com/facebookincubator/velox/pull/9432 Reviewed By: Yuhta Differential Revision: D56193789 Pulled By: pedroerp fbshipit-source-id: b25bd8df8bfba1fd7f5205e7e4976ac10455206d --- CMakeLists.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 53aaf4391775..0f2ce350f346 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -340,9 +340,7 @@ if("${ENABLE_ALL_WARNINGS}") -Wno-unused-result \ -Wno-format-overflow \ -Wno-strict-aliasing \ - -Wno-type-limits \ - -Wno-stringop-overflow \ - -Wno-stringop-overread") + -Wno-type-limits") endif() set(KNOWN_WARNINGS