Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbolic link in path #134

Closed
2 of 6 tasks
freak4pc opened this issue Oct 3, 2020 · 3 comments
Closed
2 of 6 tasks

Support symbolic link in path #134

freak4pc opened this issue Oct 3, 2020 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@freak4pc
Copy link

freak4pc commented Oct 3, 2020

Describe the bug
If path to a file involves a symbolic link, the file is not found

Version

  • V1
  • V2

Environment

  • self-hosted
  • Linux
  • Windows
  • Mac

How to reproduce

Running as

- name: Archive production artifacts
      uses: actions/upload-artifact@v2
      with:
        name: Store executable
        path: .build

Works, and the big zip file looks as follows:

image

When trying this, though:

- name: Archive production artifacts
      uses: actions/upload-artifact@v2
      with:
        name: Store executable
        path: .build/release/prism.exe

It fail, since release is actually a symlink to to x86_64-unknown-windows-msvc/release.

Using .build/x86_64-unknown-windows-msvc/release/prism.exe directly does work.

Notice also that the downloaded ZIP contains a double copy of this since the symlink is resolved as a regular uploaded file and not counted as a symbolic link (This seems to be related to #93)

@freak4pc freak4pc added the bug Something isn't working label Oct 3, 2020
@konradpabjan konradpabjan added duplicate This issue or pull request already exists and removed bug Something isn't working labels Oct 13, 2020
@konradpabjan
Copy link
Collaborator

Closing as a dup of #92 and #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants
@freak4pc @konradpabjan and others