Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle count metric reports always 0 #3787

Open
4 tasks done
velkovb opened this issue Oct 28, 2024 · 0 comments
Open
4 tasks done

Idle count metric reports always 0 #3787

velkovb opened this issue Oct 28, 2024 · 0 comments
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@velkovb
Copy link

velkovb commented Oct 28, 2024

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Set minRunners for a specific scale set to 4.
2. Go to the metrics endpoint of a listener pod.
3. Check `gha_idle_runners` metrics and it is 0.
4. Go to your runners settings in Github. Find the specific runner.
5. Search for the runner name and you will see 4 idle runners.

Describe the bug

gha_idle_runners is always returned as 0 despite there being idle runners.

Describe the expected behavior

gha_idle_runners is properly returned as the number of idle runners.

Additional Context

affinity:
  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
      - matchExpressions:
        - key: role
          operator: In
          values:
          - spot
fullnameOverride: gha-runner-scale-set-controller
metrics:
  controllerManagerAddr: :8080
  listenerAddr: :8081
  listenerEndpoint: /metrics
priorityClassName: system-cluster-critical
replicaCount: 1
resources:
  limits:
    memory: 512Mi
  requests:
    cpu: 200m
    memory: 512Mi
tolerations:
- effect: NoSchedule
  key: pot
  operator: Equal
  value: "true"

Controller Logs

https://gist.github.com/velkovb/61706771a1b7a9d6f27af4d50c63ca35

Runner Pod Logs

There are no runner pods here.
@velkovb velkovb added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

1 participant