Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Proxmox Backup Server (PBS) Support #6187

Closed
mlinares1998 opened this issue Jan 5, 2025 · 2 comments
Closed

Feature request: Add Proxmox Backup Server (PBS) Support #6187

mlinares1998 opened this issue Jan 5, 2025 · 2 comments

Comments

@mlinares1998
Copy link

Steps to reproduce

Right now the current Proxmox VE deploy hook script isn't compatible with Proxmox Backup Server as is, due slight API differences.
Based upon my tests the differences are the following:

  1. PBS listens on port 8007 by default.

  2. PBS doesn't support user defined roles, you must create an API Token with /system/certificates path and Admin role which includes Sys.Modify permissions.
    image

  3. PBS API Authorization header format is different -> Authorization: PBSAPIToken=TOKENID:TOKENSECRET

  4. The certificates update API endpoint is the same as PVE, where the node is the PBS instance nickname (shown in dashboard).
    pbs.example.com:8007/api2/json/nodes/{node}/certificates/custom

  5. The JSON Payload is almost the same, as PVE but "restart" and "force" keys are switched to <true|false> instead <0|1> as PVE.
    https://pbs.proxmox.com/docs/api-viewer/index.html#/nodes/{node}/certificates/custom
    Example:

{
  "certificates": "-----BEGIN CERTIFICATE-----",
  "key": "-----BEGIN RSA PRIVATE KEY-----",
  "node":"pbs",
  "restart": true,
  "force": true
}

The current PVE deploy hook script can be easily adapted with these changes.
I have tested the API calls with Postman and was able to update the certs successfully via the API.

If you agree i can make a PR with the adapted script.
Regards!!

Copy link

github-actions bot commented Jan 5, 2025

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

@HTDemony
Copy link

HTDemony commented Jan 9, 2025

@Neilpang Neilpang closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants