Query constructor for grouped models injects field name instead of SPARQL binding #161
Assignees
Labels
bug
Something isn't working
Comments
lu-pl
changed the title
|
This is clearly a design flaw, there should be a single interface for resolving aliases -> refactor todo! |
class FieldsBindingsMap(UserDict):
def __init__(self, model: type[_TModelInstance]):
self.data = self._get_field_binding_mapping(model)
@staticmethod
def _get_field_binding_mapping(model: type[_TModelInstance]) -> dict[str, str]:
return {
k: next(filter(lambda x: isinstance(x, SPARQLBinding), v.metadata), k)
for k, v in model.model_fields.items()
} |
lu-pl
added a commit
that referenced
this issue
Dec 5, 2024
Currently, query constructors naively inject the 'group_by' value from the model_config into SPARQL queries; this works until a field name does not correspond to a SPARQL binding name i.e. until rdfproxy.SPARQLBinding aliases are used. So, field-based grouping obviously requires 'group_by' values to resolve SPARQL binding aliases - which this change implements. Note: The change introduces duplication for resolving SPARQL binding aliases. The planned QueryConstructor class (issue #134) will get rid of this and other design flaws. Fixes #161
lu-pl
added a commit
that referenced
this issue
Dec 5, 2024
Currently, query constructors naively inject the 'group_by' value from the model_config into SPARQL queries. This works until a field name does not correspond to a SPARQL binding name, i.e. until rdfproxy.SPARQLBinding aliases are used. So, field-based grouping obviously requires 'group_by' values to resolve SPARQL binding aliases - which this change implements. Note: The change introduces duplication for resolving SPARQL binding aliases. The planned QueryConstructor class (issue #134) will get rid of this and other design flaws. Fixes #161
kevinstadler
pushed a commit
that referenced
this issue
Dec 5, 2024
Currently, query constructors naively inject the 'group_by' value from the model_config into SPARQL queries. This works until a field name does not correspond to a SPARQL binding name, i.e. until rdfproxy.SPARQLBinding aliases are used. So, field-based grouping obviously requires 'group_by' values to resolve SPARQL binding aliases - which this change implements. Note: The change introduces duplication for resolving SPARQL binding aliases. The planned QueryConstructor class (issue #134) will get rid of this and other design flaws. Fixes #161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apparently, the query constructor for grouped models injects the field name instead of the SPARQL binding name when
rdfproxy.SPARQBindingaliasing is used.This is almost certainly connected with the change to model field grouping, the aliasing is handled in the mapper but also needs handling in the query constructor.
The text was updated successfully, but these errors were encountered: