Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application to auth token params #1167

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Aug 31, 2024

This uses the new param from accentor/api#622

I went with the format WEB vX.Y.Z but am open to other suggestions.

Manual tests:

  • Logging in creates an auth token with the appropriate application attribute
  • Running yarn build creates a bundle that directly contains the version from package.json

@robbevp robbevp added the enhancement New feature or request label Aug 31, 2024
@robbevp robbevp requested a review from chvp August 31, 2024 12:12
@robbevp robbevp self-assigned this Aug 31, 2024
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just published new version of api and api-client-js. While this doesn't strictly need any of the changes in api-client-js it would be better to also bump it in this PR, IMO.

src/version.js Outdated
@@ -0,0 +1 @@
export const APPLICATION_VERSION = `WEB v${require("../package.json").version}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do this through the vue config (e.g. something like this: https://medium.com/hceverything/how-to-show-your-app-version-from-package-json-in-your-vue-application-11e882b97d8c). Reading the package.json in actual application code doesn't feel that nice.

Also, I would just write Accentor Web v${version}.

@robbevp robbevp requested a review from chvp September 5, 2024 18:16
@robbevp robbevp force-pushed the enhc/add-application-to-login branch from 8abd9a0 to 47cf383 Compare September 5, 2024 18:16
@robbevp robbevp force-pushed the enhc/add-application-to-login branch from 47cf383 to c179273 Compare September 5, 2024 18:17
@chvp chvp merged commit 7d04a71 into main Sep 5, 2024
3 checks passed
@chvp chvp deleted the enhc/add-application-to-login branch September 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants