Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when commiting tracks #25

Open
robbevp opened this issue Aug 7, 2021 · 2 comments
Open

Memory leak when commiting tracks #25

robbevp opened this issue Aug 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@robbevp
Copy link
Member

robbevp commented Aug 7, 2021

When fetching the tracks, the whole app is blocked on each commit. This takes progressively longer the more tracks are loaded.

You can clearly see this by:

  • Added a console.debug at the end of setTracks. The gap between this debug and the store's debuger reporting will got bigger and bigger.

Tried:

  • Just loading the tracks and not displaying any UI or using any computed values
  • Freezing the tracks before adding them to the store
  • Wrap the whole state.tracks in Object.freeze

Worked:

  • Only update localStorage when one of the modules changed made a small improvement.
@robbevp robbevp added the bug Something isn't working label Aug 7, 2021
@robbevp
Copy link
Member Author

robbevp commented Aug 8, 2021

@chvp If you have time to take a look. I can't seem to figure this out.
This uses the same structure as Accentor/web, but introduces a memory leak (or at least, a blocked UI while mutating the store) - probably due to a change in Vue's reactivity system.

@chvp
Copy link
Member

chvp commented Aug 14, 2021

Seems like you're running into vuejs/core#2380 / vuejs/vuex#1847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants