-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to rate albums #2
Comments
Been thinking about how we would structure this. Airsonic allows both favourites and a rating, which feels redundant to me.
|
I'm not sure I agree that ratings make more sense than a favourite for albums. What would be the use for a rating system that wouldn't be covered by favs? Do we expect users to rank albums by rating? Do we want to calculate averages over users? Do we want dynamic collages that include albums above a certain rating? To me, the answer to all those questions is no. I wouldn't make this too generic. We don't expect other models to pop up where favouriting or rating would make sense and a little duplication to keep things simple feels like the better option to me. |
A rating has the benefit of allowing more nuance. With a favs, an album either is a favourite or the value isn't set (it would be pretty unusual to distinguish between false and nil for this kind of thing). So this leaves no way to dislike something, or give it a mediocre opinion. That doesn't mean that I necessarily want ratings over favs. Giving something 2/5 instead of 3/5 can feel very abitrary, but there is an inherit benefit to ratings over favs.
But you agree with doing albums, artists and tracks, right? |
I get the benefit of allowing ratings, I just don't see a usecase within accentor for allowing ratings over favs. I agree with albums, artists and tracks, yes. |
The fact that a user might want to give a more nuanced rating rather then a favourite would be a usecase in itself, no? |
I don't thinks so? Accentor is a music player at heart, I don't see how being able to give a nuanced rating helps that core idea. |
No description provided.
The text was updated successfully, but these errors were encountered: