Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a mechanism to populate the dns_alt_names key in puppet.conf for the master. #23

Open
wolfspyre opened this issue Aug 2, 2014 · 2 comments
Milestone

Comments

@wolfspyre
Copy link

we likely want to provide the user the ability to populate dns_alt_names on their master.

@rendhalver rendhalver added this to the v1.8.1 milestone Feb 18, 2015
@rendhalver
Copy link
Member

This is definitely something that won't have much effect on a running system with a pre existing cert.
The dns_alt_names setting needs to be set before a cert is generated so should be part of system provisioning.

divansantana pushed a commit to divansantana/abstractit-puppet that referenced this issue May 12, 2016
Support for dns_alt_names configuration in puppet master.

Fixes abstractitptyltd#23
divansantana added a commit to divansantana/abstractit-puppet that referenced this issue May 25, 2016
Support for dns_alt_names configuration in puppet master.

Fixes abstractitptyltd#23
divansantana added a commit to divansantana/abstractit-puppet that referenced this issue May 25, 2016
Support for dns_alt_names configuration in puppet master.

Fixes abstractitptyltd#23
@divansantana
Copy link
Contributor

@rendhalver So, initially I didn't quite understand your above comment when I read this issue and I noticed it as open and thought I'd try address it.

Anyway, now I understand what you were saying.

However, I'd still like to get this patch merged if you're OK with it. I've tested it properly and it works nicely.

It can and is useful to have it in, because (a) one can you this/your module to bootstrap/provision the initial Puppet CA. I've done that in our environment. So the first puppet CA starts up correctly using the module. (b) it's also nice to have this configured on the puppet CA after it's up and running from a consistency/clarity point of view, even though it has no impact once it's up and running. It does at least show to others how the CA was generated/initially configured.

PS. My previous PR had issues, this one should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants