-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests revisited #986
Open
Khalid-Jalal
wants to merge
28
commits into
develop
Choose a base branch
from
TestsRevisited
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tests revisited #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ade in such a way, that the pumpandsettle method would change a needed state on mondays.
…dded for more clarity
…ty. Two test needs to be revisited
Updated tests: - copy_resolve_bloc_test.dart - pictogram_bloc_test.dart - environment_test.dart - giraf_app_bar_widget_test.dart
…nner into TestsRevisited
Fixed TODOs on lines 120 and 127 of the tests
1 task
* Fixed Errors with merge * Fixed GitHub nickpicks * Fixed test not being correctly merged * Fixed weekplans_bloc_test.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revisited tests (except screens folder)
Added documentation for tests and made corrections.
Fixes #<issue_no>
Type of change
Delete unchecked boxes (only for Type of change)
How Has This Been Tested?
Added documentation for tests. Tested using the Flutter framework to make sure the test is correct. using VS code and Android Studio.
Development Configuration
Type "flutter --version" and "dart --version" in your CMD to check versions.
Checklist: