Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring unit-tests related to weekplans_bloc_test #980

Open
Fatma-Mondher opened this issue Nov 27, 2023 · 0 comments
Open

Refactoring unit-tests related to weekplans_bloc_test #980

Fatma-Mondher opened this issue Nov 27, 2023 · 0 comments
Assignees

Comments

@Fatma-Mondher
Copy link

Fatma-Mondher commented Nov 27, 2023

This issue is an extension of issue #565

Weekplans_bloc_test tests functionality related to weekplan_selector_bloc. There are however a number of problems related to the test file. Two of the tests have been commented out and fails when run and therefore needs to be tested. In addition, the choice of tests conducted in the file is not immediately transparent due to lack of or inadequate commenting. It seems that there are functionality in weekplan_selector_bloc that is not tested properly in the file. For this reason the following changes are suggsted:

  1. Change of name of tests to conform to normal naming conventions.
  2. Fixing of commented out unit tests
  3. Implementation of unit tests of those functions that are not tested in the current version of the test-file
  4. Suggestions for refactoring functions in weeplan_selector_bloc that serve to extract week numbers from date with non-custom made functions.
  5. Suggestions for refactoring functions in weekplan_selector_bloc that do not conform to bloc architecture.
@clahanse clahanse changed the title Unit-test refactoring Refactoring unit-tests related to weekplans_test_bloc Dec 3, 2023
@clahanse clahanse changed the title Refactoring unit-tests related to weekplans_test_bloc Refactoring unit-tests related to weekplans_bloc_test Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants