Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help in understanding asset generation and also with GH actions #10

Open
milanchheda opened this issue Jan 18, 2022 · 1 comment
Open

Comments

@milanchheda
Copy link

Hey @aarondfrancis,

First of all thanks for this excellent package. Appreciate your efforts.

So, I have installed this packages and updated my deployment bash script as mentioned on the docs page

After making this changes, I ran the deployment script to check if npm run prod takes lesser time but it wasn't the case (previously it was taking ~8000ms too).

image

Am I missing some point here?

Secondly as of now, I am using FilesystemDriver so the built files are stored on the same disk inside the storage folder. I want to move to GH actions and wanted some help/understanding, if possible. So, I saw the GH workflow file changes mentioned on the doc here but can you help me when should this workflow be executed? should it be after every merge? ... And how does deployment script change when using GH actions?

Thanks,
Milan

@aarondfrancis
Copy link
Owner

Hey @milanchheda,

Using Airdrop, you would skip the npm run prod step altogether. Airdrop will download built assets and put them in place so that you don't have to run the build step at all.

As for GH actions, you would perhaps run this as a part of your deployment workflow. So if you're deploying from GHA, you can use Airdrop to skip the asset building if you wanted!

Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants