Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in calculating edges based on k nearest neighbors #410

Open
tsjain opened this issue Aug 23, 2024 · 0 comments
Open

Bug in calculating edges based on k nearest neighbors #410

tsjain opened this issue Aug 23, 2024 · 0 comments

Comments

@tsjain
Copy link

tsjain commented Aug 23, 2024

In order to exclude residues less than long_interaction_threshold, the code checks for residue_number value in the pdb dataframe. The residue_number value is identical for residues with insertion codes. Therefore, it will not create neighboring edges between residues that have the same number but differ in the insertion code.

This is very severe bug because insertion codes are very common in protein structures.

n1_position = pdb_df.loc[a1, "residue_number"]
n2_position = pdb_df.loc[a2, "residue_number"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant